Update Typesync #312

lishaduck · 2024-12-03T21:43:47Z

Closes #295, closes #297, closes #193.

changeset-bot · 2024-12-03T21:43:51Z

⚠️ No Changeset found

Latest commit: 391a110

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-12-03T21:43:52Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sheriff	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 5, 2025 1:56am

lishaduck · 2024-12-03T21:47:01Z

Works (correctly fails on Windows)!

AndreaPontrandolfo · 2024-12-03T22:49:04Z

Yo @lishaduck, thank you as always!

Im having some real-life trouble right now, so i will probably be unable to review PRs this week And even the next.

AndreaPontrandolfo · 2025-01-01T23:17:19Z

turbo.json

@@ -37,7 +37,9 @@
    },
    "//#manypkg": {},
    "//#knip": {},
-    "typesync": {},
+    "//#typesync": {
+      "inputs": ["**/package.json", ".typesyncrc"]


uhm, either we don't specify the inputs or we add an empty .typesyncrc file. Otherwise the first time that we add a config file for typescync we are gonna run into trouble.

I thought I'd added a .typesyncrc file, but even if not, is there an issue with specifying a non-existent file?

is there an issue with specifying a non-existent file?

Definitely yes. It creates confusion both now and for our future selfs.

still waiting on this

AndreaPontrandolfo

@lishaduck

Please remove the whole tilde (~) thing. It's not needed and it makes my head spin.

AndreaPontrandolfo · 2025-01-01T23:28:00Z

turbo.json

@@ -37,7 +37,9 @@
    },
    "//#manypkg": {},
    "//#knip": {},
-    "typesync": {},
+    "//#typesync": {
+      "inputs": ["**/package.json", ".typesyncrc"]


is there an issue with specifying a non-existent file?

Definitely yes. It creates confusion both now and for our future selfs.

lishaduck · 2025-01-02T01:20:11Z

Please remove the whole tilde (~) thing. It's not needed and it makes my head spin.

I can, but first, can you read the rational?

Pedantically, the most correct thing would be to pin types to =, but that's a bit over top. ~ balances it.

AndreaPontrandolfo · 2025-01-02T15:24:35Z

Please remove the whole tilde (~) thing. It's not needed and it makes my head spin.

I can, but first, can you read the rational?

I did. Still don't get it.

As an example, think about Lodash. Lodash stopped being updated 9 years ago. What does it matter which version of the typings we are importing? Of course we want the latest.

Seriously i don't want to deal with any of that.

lishaduck · 2025-01-02T16:42:41Z

I did. Still don't get it.

As an example, think about Lodash. Lodash stopped being updated 9 years ago. What does it matter which version of the typings we are importing? Of course we want the latest.

Lodash v4 is still "in progress", but let's take react:
Say you're a package with a minimum dependency on React "^18.1", and React 18.2.0 comes out. You could upgrade the types package to 18.2.0, but then you wouldn't get any warning when you use 18.2.0 features, and could inadvertently make a breaking change. With a lockfile, you have to manually upgrade either way, so it doesn't really make a difference if you want the latest, you'll get an older version until you upgrade either way.

Seriously i don't want to deal with any of that.

I'll go change it, I just wanted to ensure you understood the why.

AndreaPontrandolfo · 2025-01-02T18:36:12Z

turbo.json

@@ -37,7 +37,9 @@
    },
    "//#manypkg": {},
    "//#knip": {},
-    "typesync": {},
+    "//#typesync": {
+      "inputs": ["**/package.json", ".typesyncrc"]


still waiting on this

AndreaPontrandolfo · 2025-01-02T18:37:17Z

@lishaduck on a side note, does pnpm dev works on your end? It's still broken on mine.

Closes: AndreaPontrandolfo#193. # Conflicts: # pnpm-lock.yaml

lishaduck · 2025-01-02T19:19:54Z

@lishaduck on a side note, does pnpm dev works on your end? It's still broken on mine.

I'd gotten it working, but it seems to have broken again.

lishaduck · 2025-01-02T19:41:43Z

@lishaduck on a side note, does pnpm dev works on your end? It's still broken on mine.

I'd gotten it working, but it seems to have broken again.

Made some tweaks. It's easy enough to get to work, but it's a little finicky. Are you fine with removing dev:norebuild (the issues are just that I didn't want to break it)?

lishaduck · 2025-01-02T19:49:47Z

Are you fine with removing dev:norebuild (the issues are just that I didn't want to break it)?

I think I figured out how to fix it.

lishaduck · 2025-01-03T18:26:37Z

@AndreaPontrandolfo, ping

(I'd like to get all my open PRs here and in fsecond merged today, if possible, as school restarts on Monday.)

turbo.json

Not quite optimal, and requires a bit of bootstrapping, but it works alright.

vercel bot deployed to Preview December 3, 2024 21:44 View deployment

lishaduck force-pushed the typesync-update branch from 1b6df01 to 3da74a9 Compare December 3, 2024 23:05

vercel bot deployed to Preview December 3, 2024 23:06 View deployment

lishaduck force-pushed the typesync-update branch from 3da74a9 to e1a7793 Compare December 3, 2024 23:16

vercel bot had a problem deploying to Preview December 3, 2024 23:16 Failure

lishaduck force-pushed the typesync-update branch from e1a7793 to 523470a Compare December 3, 2024 23:20

vercel bot deployed to Preview December 3, 2024 23:21 View deployment

lishaduck mentioned this pull request Dec 13, 2024

'ERR_UNKNOWN_FILE_EXTENSION' jeffijoe/typesync#136

Open

lishaduck force-pushed the typesync-update branch from 523470a to 0db1df7 Compare December 31, 2024 20:15

lishaduck mentioned this pull request Dec 31, 2024

fix: root typesync #297

Closed

lishaduck changed the title ~~Typesync update~~ Update Typesync Dec 31, 2024

vercel bot deployed to Preview December 31, 2024 20:16 View deployment

lishaduck force-pushed the typesync-update branch from 0db1df7 to 034b500 Compare December 31, 2024 20:23

vercel bot had a problem deploying to Preview December 31, 2024 20:24 Failure

lishaduck force-pushed the typesync-update branch from 034b500 to d31b204 Compare December 31, 2024 22:15

vercel bot deployed to Preview December 31, 2024 22:16 View deployment

lishaduck force-pushed the typesync-update branch from d31b204 to b1eb286 Compare January 1, 2025 02:41

vercel bot deployed to Preview January 1, 2025 02:42 View deployment

lishaduck force-pushed the typesync-update branch from b1eb286 to 2e4ffc3 Compare January 1, 2025 16:46

vercel bot deployed to Preview January 1, 2025 16:46 View deployment

lishaduck force-pushed the typesync-update branch from 2e4ffc3 to 0cd180e Compare January 1, 2025 18:31

vercel bot deployed to Preview January 1, 2025 18:32 View deployment

AndreaPontrandolfo requested changes Jan 1, 2025

View reviewed changes

lishaduck force-pushed the typesync-update branch from 0cd180e to d6f931e Compare January 2, 2025 17:33

vercel bot deployed to Preview January 2, 2025 17:33 View deployment

lishaduck requested a review from AndreaPontrandolfo January 2, 2025 18:09

AndreaPontrandolfo requested changes Jan 2, 2025

View reviewed changes

lishaduck added 2 commits January 2, 2025 13:08

chore(deps): bump typesync, use monorepo support

43d7038

Closes: AndreaPontrandolfo#193. # Conflicts: # pnpm-lock.yaml

chore(deps): refresh typesync'd deps

e6ae056

lishaduck force-pushed the typesync-update branch from d6f931e to e6ae056 Compare January 2, 2025 19:08

vercel bot deployed to Preview January 2, 2025 19:09 View deployment

lishaduck requested a review from AndreaPontrandolfo January 2, 2025 19:17

vercel bot deployed to Preview January 2, 2025 19:44 View deployment

lishaduck force-pushed the typesync-update branch from 6e3b5b1 to c2af5c6 Compare January 2, 2025 20:07

vercel bot deployed to Preview January 2, 2025 20:08 View deployment

AndreaPontrandolfo requested changes Jan 4, 2025

View reviewed changes

turbo.json Outdated Show resolved Hide resolved

fix: pnpm dev

391a110

Not quite optimal, and requires a bit of bootstrapping, but it works alright.

lishaduck force-pushed the typesync-update branch from c2af5c6 to 391a110 Compare January 5, 2025 01:55

lishaduck requested a review from AndreaPontrandolfo January 5, 2025 01:56

vercel bot deployed to Preview January 5, 2025 01:56 View deployment

AndreaPontrandolfo approved these changes Jan 5, 2025

View reviewed changes

AndreaPontrandolfo merged commit 02da6c9 into AndreaPontrandolfo:master Jan 5, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Typesync #312

Update Typesync #312

lishaduck commented Dec 3, 2024

changeset-bot bot commented Dec 3, 2024 •

edited

Loading

vercel bot commented Dec 3, 2024 •

edited

Loading

lishaduck commented Dec 3, 2024 •

edited

Loading

AndreaPontrandolfo commented Dec 3, 2024 •

edited

Loading

AndreaPontrandolfo Jan 1, 2025

lishaduck Jan 1, 2025

AndreaPontrandolfo Jan 1, 2025

AndreaPontrandolfo Jan 2, 2025

AndreaPontrandolfo left a comment

AndreaPontrandolfo Jan 1, 2025

lishaduck commented Jan 2, 2025

AndreaPontrandolfo commented Jan 2, 2025

lishaduck commented Jan 2, 2025

AndreaPontrandolfo Jan 2, 2025

AndreaPontrandolfo commented Jan 2, 2025

lishaduck commented Jan 2, 2025

lishaduck commented Jan 2, 2025 •

edited

Loading

lishaduck commented Jan 2, 2025

lishaduck commented Jan 3, 2025 •

edited

Loading

Update Typesync #312

Update Typesync #312

Conversation

lishaduck commented Dec 3, 2024

changeset-bot bot commented Dec 3, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Dec 3, 2024 • edited Loading

lishaduck commented Dec 3, 2024 • edited Loading

AndreaPontrandolfo commented Dec 3, 2024 • edited Loading

AndreaPontrandolfo Jan 1, 2025

Choose a reason for hiding this comment

lishaduck Jan 1, 2025

Choose a reason for hiding this comment

AndreaPontrandolfo Jan 1, 2025

Choose a reason for hiding this comment

AndreaPontrandolfo Jan 2, 2025

Choose a reason for hiding this comment

AndreaPontrandolfo left a comment

Choose a reason for hiding this comment

AndreaPontrandolfo Jan 1, 2025

Choose a reason for hiding this comment

lishaduck commented Jan 2, 2025

AndreaPontrandolfo commented Jan 2, 2025

lishaduck commented Jan 2, 2025

AndreaPontrandolfo Jan 2, 2025

Choose a reason for hiding this comment

AndreaPontrandolfo commented Jan 2, 2025

lishaduck commented Jan 2, 2025

lishaduck commented Jan 2, 2025 • edited Loading

lishaduck commented Jan 2, 2025

lishaduck commented Jan 3, 2025 • edited Loading

changeset-bot bot commented Dec 3, 2024 •

edited

Loading

vercel bot commented Dec 3, 2024 •

edited

Loading

lishaduck commented Dec 3, 2024 •

edited

Loading

AndreaPontrandolfo commented Dec 3, 2024 •

edited

Loading

lishaduck commented Jan 2, 2025 •

edited

Loading

lishaduck commented Jan 3, 2025 •

edited

Loading